Conversation
p-
requested review from
JarLob,
kevinbackhouse,
m-y-mo and
sylwia-budzynska
as code owners
m-y-mo
approved these changes
Dec 18, 2025
Contributor
|
Probably need to do it with seclab-taskflow-agent also? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the LOG_DIR environment variable to all MCP (Model Context Protocol) server configuration files, enabling MCP servers to use a centralized logging directory defined at the system level.
- All 9 MCP server toolbox YAML configurations are updated to include the LOG_DIR environment variable
- The variable is consistently added as the last entry in each server's env section
- Uses the standard template syntax
{{ env LOG_DIR }}to pass the globally defined LOG_DIR value
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| report_alert_state.yaml | Adds LOG_DIR env var for alert state reporting MCP server |
| repo_context.yaml | Adds LOG_DIR env var for repository context MCP server |
| local_gh_resources.yaml | Adds LOG_DIR env var for local GitHub resources MCP server |
| local_file_viewer.yaml | Adds LOG_DIR env var for local file viewer MCP server |
| ghsa.yaml | Adds LOG_DIR env var for GHSA (GitHub Security Advisory) MCP server |
| gh_file_viewer.yaml | Adds LOG_DIR env var for GitHub file viewer MCP server |
| gh_code_scanning.yaml | Adds LOG_DIR env var for GitHub code scanning MCP server |
| gh_actions.yaml | Adds LOG_DIR env var for GitHub Actions MCP server |
| codeql_python.yaml | Adds LOG_DIR env var for CodeQL Python MCP server |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kiandadban
pushed a commit
to kiandadban/seclab-taskflows
that referenced
this pull request
May 4, 2026
…-log-env-mcp provide LOG_DIR env var to MCP servers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this way the MCP servers will log into the "globally" defined LOG_DIR